Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write test for de-serialization potential error #104

Merged
merged 1 commit into from
Dec 2, 2024
Merged

write test for de-serialization potential error #104

merged 1 commit into from
Dec 2, 2024

Conversation

rkeur7
Copy link
Contributor

@rkeur7 rkeur7 commented Nov 25, 2024

@rkeur7 rkeur7 requested review from AdrianCollinsShippo and a team as code owners November 25, 2024 22:49
@rkeur7 rkeur7 mentioned this pull request Nov 25, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Tests Skipped Failures Errors Time
15 0 💤 0 ❌ 0 🔥 24.805 ⏱

AdrianCollinsShippo
AdrianCollinsShippo approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@AdrianCollinsShippo AdrianCollinsShippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably fine - just left one question.

tests/test_carrier_accounts.py Show resolved Hide resolved
@rkeur7 rkeur7 merged commit 844f3c4 into main Dec 2, 2024
4 checks passed
@rkeur7 rkeur7 deleted the CET-394 branch December 2, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianCollinsShippo AdrianCollinsShippo AdrianCollinsShippo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkeur7 @AdrianCollinsShippo